Miri Frame: use mir::Location to represent position in function #71475
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
RalfJung
force-pushed
the
miri-frame-loc
branch
from
de7023e
to
90f1131
Compare
|
r=me once CI is green. @bors delegate+ |
|
✌️ @RalfJung can now approve this pull request |
|
@bors r=ecstatic-morse |
|
📌 Commit 90f1131 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 24, 2020
Rollup of 5 pull requests Successful merges: - rust-lang#71235 (Tweak `'static` suggestion code) - rust-lang#71318 (miri-unleash tests: ensure they fire even with 'allow(const_err)') - rust-lang#71428 (Let compiletest recognize gdb 10.x) - rust-lang#71475 (Miri Frame: use mir::Location to represent position in function) - rust-lang#71476 (more compact way to adjust test sizes for Miri) Failed merges: r? @ghost
|
☔ The latest upstream changes (presumably #71509) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I only recently learned that
Locationexists, and it seems to perfectly fit what Miri needs to represent which statement we are currently executing. :)r? @ecstatic-morse